Video: Amazing Code Reviews

November 6th, 2020

Amazing Code Reviews

 

https://www.youtube.com/watch?v=ly86Wq_E18o

no description for image available

 

1) build the right thing

show direction

early

to minimize rework

 

no description for image available

draft PR (github)

- cannot be merged

- don't ping code owners

- communicates 'draft'

 

2) build the thing right

 

no description for image available

 

stacked PR

(pr that depend on each other)

 

Toolbelt

- well organized commits

- github base branches

- stacked PRs

 

1 PR == 1 concern

no description for image available

 

 

no description for image available

 

 

3) Build it fast

no description for image available

 

PR is not great for crowd discussion

-> meeting

add results of meeting to PR

 

 

no description for image available

 

 

no description for image available

 

no description for image available

 

no description for image available

shared responsibility

 

no description for image available