Amazing Code Reviews

https://www.youtube.com/watch?v=ly86Wq_E18o ./resources/video-amazing-code-reviews.1.resources/screenshot.png

  1. build the right thing show direction early to minimize rework

./resources/video-amazing-code-reviews.1.resources/screenshot.1.png draft PR (github) - cannot be merged - don’t ping code owners - communicates ‘draft’

  1. build the thing right

./resources/video-amazing-code-reviews.1.resources/screenshot.2.png

stacked PR (pr that depend on each other)

Toolbelt - well organized commits - github base branches - stacked PRs

1 PR == 1 concern ./resources/video-amazing-code-reviews.1.resources/screenshot.3.png

./resources/video-amazing-code-reviews.1.resources/screenshot.4.png

  1. Build it fast ./resources/video-amazing-code-reviews.1.resources/screenshot.5.png

PR is not great for crowd discussion -> meeting add results of meeting to PR

./resources/video-amazing-code-reviews.1.resources/screenshot.6.png

./resources/video-amazing-code-reviews.1.resources/screenshot.7.png

./resources/video-amazing-code-reviews.1.resources/screenshot.8.png

./resources/video-amazing-code-reviews.1.resources/screenshot.9.png shared responsibility

./resources/video-amazing-code-reviews.1.resources/screenshot.10.png